Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix package name in babel config docs #10666

Merged
merged 1 commit into from
Nov 11, 2024
Merged

docs: fix package name in babel config docs #10666

merged 1 commit into from
Nov 11, 2024

Conversation

kyletsang
Copy link
Contributor

@kyletsang kyletsang commented Nov 10, 2024 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The documentation for customizing the babel config says to install @docusaurus/theme-live-codeblock, then use the @docusaurus/babel/preset in the config file. This should tell the user to install @docusaurus/babel instead.

Test Plan

N/A

Test links

Deploy preview: https://deploy-preview-10666--docusaurus-2.netlify.app/

Related issues/PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 10, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 10, 2024

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 89c96c4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67312be9e9318800082dd276
😎 Deploy Preview https://deploy-preview-10666--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟢 93 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 60 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 65 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 65 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Nov 11, 2024
@slorber
Copy link
Collaborator

slorber commented Nov 11, 2024

thanks 👍

@slorber slorber merged commit 0c86355 into facebook:main Nov 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyletsang @slorber @facebook-github-bot